First Flight #16: Mafia Takedown

Description

godFather assigns weapons to GangMembers using the Laundrette::putGunsInTheSuspendedCeiling function and it makes a change in the mapping of WeaponShelf but with lack of events both the unassigned accounts and the withdrawn accounts will have a weapon count of 0 and it will be very difficult to know if the weapons are withdrawn or unassigned.

Impact

godFather may loose track of the weapons in the WeaponShelf and it will be very difficult to know if the weapons are withdrawn or unassigned .

Proof of Concept

The initial value of a mapping i.e unassigned is same as the accounts which have withdrawn the weapons assigned to them.

Recommended Mitigation

Since the WeaponShelf itself has no proper implementation other than a keycode and inherited shelf contract it is recommended to use ERC721 i.e NFT's for weapons (since each weapon is unique and hence non fungible) and the logic to be implemented in WeaponShelf.sol .