Beginner FriendlyDeFiFoundry
100 EXP
View results
Submission Details
Severity: medium
Invalid

`godFather` should be able to remove `GangMembers`

Description

If a GangMember is found to be Malicious then godFather should be able to remove them from them by calling a function

Impact

Malicous gangmembers cannot be removed unless they themselves quit.

Proof of Concept

  1. User joins the gang with godFather's approval

  2. User tries to be Malicious and everyone know that

  3. Now there is no way to remove the GangMember unless they quit themselves.

Recommended Mitigation

Adding a new function Laundrette::removeFromGang with the isGodFather modifier to the Laundrette.sol will ensure that godFather can remove Malicious GangMembers.

function removeFromGang(address account) external isGodFather {
kernel.revokeRole(Role.wrap("gangmember"), account);
}
Updates

Lead Judging Commences

n0kto Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.