Submission Details
Severity:
L-02. Unnecessary modifier for addToTheGang
Summary
The method Laundrette::addToTheGang has useless modifier onlyRole("gangmember") because it already has isGodFather
Vulnerability Details
Since the modifier isGodFather modifier checks if the user is GodFather it's useless to check if the user is onlyRole("gangmember").
Impact
Unnecessary code.
Tools Used
Manual Review
Recommendations
Remove the onlyRole("gangmember") for Laundrette::addToTheGang.
- function addToTheGang(address account) external onlyRole("gangmember") isGodFather {
+ function addToTheGang(address account) external isGodFather {
kernel.grantRole(Role.wrap("gangmember"), account);
}
Rewards breakdown
nSLOC
205This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.