Submission Details
Severity:
L-03. Unnecessary modifier for takeGuns
Summary
The method Laundrette::takeGuns has useless modifier onlyRole("gangmember") because it already has isAuthorizedOrRevert(account) and guns are given only to gang members.
Vulnerability Details
Since the modifier isAuthorizedOrRevert(account) modifier checks if the user is the one who is meant to take guns given to him/herand also checks if the transaction sender is GodFather, then it's useless to haveonlyRole("gangmember")` modifier for the method.
Impact
Unnecessary code.
Tools Used
Manual Review
Recommendations
Remove the onlyRole("gangmember") for Laundrette::addToTheGang.
- function takeGuns(address account, uint256 amount) external onlyRole("gangmember") isAuthorizedOrRevert(account) {
+ function takeGuns(address account, uint256 amount) external isAuthorizedOrRevert(account) {
weaponShelf.withdraw(account, amount);
}
Rewards breakdown
nSLOC
205This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.