First Flight #16: Mafia Takedown
First Flight #16
Beginner FriendlyDeFiFoundry
100 EXP
View results
Previous Next
Submission Details
Severity: low
Invalid

[L-2] `EmergencyMigration::migrate` function does not update the addresses of the `Kernel`, `USDC` and `CrimeMoney` contracts as expected.

Keyword

Description: The EmergencyMigration::migrate function is supposed to erase the traces of the old addresses and set them all to address(0).

As per the natspec in the EmergencyMigration::run function, the migration should erase the traces of the old contracts.

Impact: The migration does not get rid of the old addressess of Kernel, USDC and CrimeMoney. The agency will find the old contracts and is able to use them agains the mob.

Proof of Concepts: Just run the test_migrate function inside the EmergencyMigrationTest.t.sol file and check the logs.

//
//
├─ [539499] EmergencyMigration::migrate(Kernel: [0x037eDa3aDB1198021A9b2e88C22B464fD38db3f3], 0x0000000000000000000000000000000000000001, CrimeMoney: [0xDDc10602782af652bB913f7bdE1fD82981Db7dd9])
//
//

Recommended mitigation: Ensure that the addresses are updated correctly.

Updates

Lead Judging Commences

n0kto Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.