First Flight #17: Dussehra

First Flight #17

Beginner FriendlyFoundryNFT

100 EXP

View results

Previous Next

Submission Details

Severity: medium

Valid

### [H-4] Lack of input validation in `increaseValuesOfParticipants` function for `tokenIdOfChallenger` and `tokenIdOfAnyPerticipent`

Keyword

[H-4] Lack of input validation in the `ChoosingRam::increaseValuesOfParticipants` function allows an attacker to win every time by submitting the same NFT id as both `tokenIdOfChallenger` and `tokenIdOfAnyPerticipent`.

Description: The ChoosingRam::increaseValuesOfParticipants function is supposed to update the characteristics of the NFT of the challenger if the value of the random variable is 0, otherwise, it should update the characteristics of the NFT of the tokenIdOfAnyPerticipent. Because there is no check that enforces tokenIdOfAnyPerticipent to be different than the tokenIdOfChallenger a malicious user can call this function and he is guaranteed to update his NFT every time, irrespective of what the value of random is.

Impact: A user can guarantee the update of the characteristics of his NFT, irrespective of randomness.

Proof of Concepts: Input the test below in the Dussehra.t.sol file.

PoC - Click the arrow below

function test_lackInputValidation() public {

//player 1 joins event

vm.startPrank(player1);

vm.deal(player1, 1 ether);

dussehra.enterPeopleWhoLikeRam{value: 1 ether}();

vm.stopPrank();

//player2 joins event

vm.startPrank(player2);

vm.deal(player2, 1 ether);

dussehra.enterPeopleWhoLikeRam{value: 1 ether}();

vm.stopPrank();

//make NFT of player2 `selectedRam`

vm.startPrank(player1);