Submission Details
Severity:
Missing event emission in `ChoosingRam::selectRamIfNotSelected`, `Dusshra::withdraw` and `Dussehra::killRavana` function
Summary
Missing events reduce the transparency of the contracts, making it difficult to track important state changes off-chain.
Vulnerability Details
ChoosingRam::selectRamIfNotSelected - No event emission after Ram is selected.
Dusshra::withdraw- No event emission after Ram withdraws funds.
Dussehra::killRavana - No event emission after player killed Ravana
Impact
Low - The lack of event emissions in these functions reduces transparency, making it difficult to monitor significant actions off-chain.
Tools Used
Manual review
Static analysis
Recommendations
Add event emission
+ event RamSelected(address indexed ram, uint256 indexed tokenId);
+ event RavanaKilled(uint256 totalAmountGivenToRam);
+ event RewardWithdrawn(address indexed ram, uint256 amount);
function selectRamIfNotSelected() public RamIsNotSelected OnlyOrganiser {
// ... existing code ...
+ emit RamSelected(selectedRamAddress, random);
}
function killRavana() public RamIsSelected {
// ... existing code ...
+ emit RavanaKilled(totalAmountGivenToRam);
}
function withdraw() public RamIsSelected OnlyRam RavanKilled {
// ... existing code ...
+ emit RewardWithdrawn(msg.sender, amount);
}
Updates
Lead Judging Commences
bube about 1 year ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
Info/Gas/Invalid according to docs
Rewards breakdown
nSLOC
218This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.