First Flight #17: Dussehra
First Flight #17
Beginner FriendlyFoundryNFT
100 EXP
View results
Previous Next
Submission Details
Severity: low
Invalid

Literal boolean comparisons are unnecessary.

7Cedars

[L-13] Literal boolean comparisons are unnecessary.

Description:

  • Found in src/ChoosingRam.sol

    if (random == 0) {
    if (ramNFT.getCharacteristics(tokenIdOfChallenger).isJitaKrodhah == false){
    } else if (ramNFT.getCharacteristics(tokenIdOfChallenger).isDhyutimaan == false){
    ​
    } else if (ramNFT.getCharacteristics(tokenIdOfChallenger).isVidvaan == false){
    ​
    } else if (ramNFT.getCharacteristics(tokenIdOfChallenger).isAatmavan == false){
    ​
    } else if (ramNFT.getCharacteristics(tokenIdOfChallenger).isSatyavaakyah == false){
    ​
    if (ramNFT.getCharacteristics(tokenIdOfAnyPerticipent).isJitaKrodhah == false){
    ​
    } else if (ramNFT.getCharacteristics(tokenIdOfAnyPerticipent).isDhyutimaan == false){
    ​
    } else if (ramNFT.getCharacteristics(tokenIdOfAnyPerticipent).isVidvaan == false){
    ​
    } else if (ramNFT.getCharacteristics(tokenIdOfAnyPerticipent).isAatmavan == false){
    } else if (ramNFT.getCharacteristics(tokenIdOfAnyPerticipent).isSatyavaakyah == false){
    ​

  • Found in src/Dussehra.sol

    if (peopleLikeRam[msg.sender] == true){

Recommended Mitigation: Remove == true and replace == false with !.

- if (peopleLikeRam[msg.sender] == true){
+ if (peopleLikeRam[msg.sender]){
- if (ramNFT.getCharacteristics(tokenIdOfChallenger).isJitaKrodhah == false)
+ if (!ramNFT.getCharacteristics(tokenIdOfChallenger).isJitaKrodhah)
Updates

Lead Judging Commences

bube Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Info/Gas/Invalid according to docs

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.