Submission Details
Severity:
The function `Dussehra::enterPeopleWhoLikeRam` tracks the number participants by pushing addresses into an array. This is gas inefficient.
[L-14] The function Dussehra::enterPeopleWhoLikeRam tracks the number addresses of participants by pushing them into an array. This is costs a lot of gas, it is better to use a counter instead.
Description: The function Dussehra::enterPeopleWhoLikeRam tracks the number addresses of participants by pushing them into an array. This is costs a lot of gas. It is better to use a counter instead.
Recommended Mitigation: Change WantToBeLikeRam from an address[] to a uint256 and use it as a counter.
- address[] public WantToBeLikeRam;
+ uint256 public WantToBeLikeRam;
.
.
.
peopleLikeRam[msg.sender] = true;
- WantToBeLikeRam.push(msg.sender);
+ WantToBeLikeRam++;
ramNFT.mintRamNFT(msg.sender);
.
.
.
- uint256 totalAmountByThePeople = WantToBeLikeRam.length * entranceFee;
+ uint256 totalAmountByThePeople = WantToBeLikeRam * entranceFee;
Updates
Lead Judging Commences
bube about 1 year ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
Info/Gas/Invalid according to docs
Rewards breakdown
nSLOC
218This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.