Submission Details
Severity:
There is a `null` function in `TSwapPool` which has no name & also is specified a return but doesn't return anything
Summary
-->> function (
IERC20 inputToken,
uint256 inputAmount,
IERC20 outputToken,
uint256 minOutputAmount,
uint64 deadline
)
public
revertIfZero(inputAmount)
revertIfDeadlinePassed(deadline)
-->> returns (uint256 output)
{
uint256 inputReserves = inputToken.balanceOf(address(this));
uint256 outputReserves = outputToken.balanceOf(address(this));
uint256 outputAmount = getOutputAmountBasedOnInput(
inputAmount,
inputReserves,
outputReserves
);
if (outputAmount < minOutputAmount) {
revert TSwapPool__OutputTooLow(outputAmount, minOutputAmount);
}
_swap(inputToken, inputAmount, outputToken, outputAmount);
// no returns..!!
}
Impact
The function has no name , so how to call it and distinguish it & what does it do..?
Also a return is specified and it doesn't return anything , so maybe a waste of gas and computation
Tools Used
Manual Analysis , slither
Recommendations
Name the function properly
If it doesn't return anything consider removing the return statement.
Rewards breakdown
nSLOC
276This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.