First Flight #18: T-Swap

First Flight #18
Beginner FriendlyDeFiFoundry
100 EXP
View results
Submission Details
Severity: medium
Invalid

Don't use strict equalities in `TSwapPool::revertIfZero` modifier

Summary

Description

modifier revertIfZero(uint256 amount) {
-->> if (amount == 0) {
revert TSwapPool__MustBeMoreThanZero();
}
_;
}

Tools Used

Manual Review

Recommendations

USe <= equality instead

modifier revertIfZero(uint256 amount) {
-->> if (amount <= 0) {
revert TSwapPool__MustBeMoreThanZero();
}
_;
}
Updates

Appeal created

inallhonesty Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Too generic

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.