Submission Details
Severity:
`TSwapPool::LiquidityAdded` event has parameters out of order, causing event to emit incorrect information
Vulnerability Details
When the LiquidtyAdded event is emitted in the TSwapPool::_addLiquidityMintAndTransfer, it logs values in the incorrect order. The poolTokensToDeposit value should go to the 3rd parameter position, whereas the wethToDeposit should go to 2nd.
Impact
The emit emission is incorrect, causing off-chain functions potentially malfunctioning.
Tools Used
Manual review, Foundry.
Recommendations
Perform the following modifications:
- emit LiquidityAdded(msg.sender, poolTokensToDeposit, wethToDeposit);
+ emit LiquidityAdded(msg.sender, wethToDeposit, poolTokensToDeposit);
Updates
Appeal created
inallhonesty about 1 year ago
Submission Judgement Published Assigned finding tags:
`LiquidityAdded` event has parameters out of order
Rewards breakdown
nSLOC
276This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.