Submission Details
Severity:
event parameter mismatch in `TSwapPool::LiquidityAdded` Event
Summary
event parameter mismatch in TSwapPool::LiquidityAdded Event
Vulnerability Details
The TSwapPool::LiquidityAddedevent has 3 parameter liquidityProvider,wethDeposited,poolTokensDeposited when it was emitted in the _addLiquidityMintAndTransfer function the arguments weren't in order. The arguments wethDeposited and poolTokensDeposited positions were swapped. The argument position should be in order liquidityProvider,wethDeposited,poolTokensDeposited just as the event requires
Impact
Off-chain applications who uses the event parameter would receive wrong data
Tools Used
Manual review
Recommendations
- emit LiquidityAdded(msg.sender, poolTokensToDeposit, wethToDeposit);
+ emit LiquidityAdded(msg.sender, wethToDeposit, poolTokensToDeposit);
Updates
Appeal created
inallhonesty about 1 year ago
Submission Judgement Published Assigned finding tags:
`LiquidityAdded` event has parameters out of order
Rewards breakdown
nSLOC
276This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.