Submission Details
Severity:
`TSwapPool::deposit` function has no deadline check which will stop transactions from being sent after deadline
Summary The deposit function accepts a deadline parameter which is never used
Vulnerability Details The TSwapPool::deposit function in accepts a deadline parameter, which according to the Nat Spec is "The deadline for the transaction to be completed by". This parameter is never used. Liquidity Providers can still deposit after the deadline when the contract does not expect any deposit
Liquidity Providers could call deposit function after the deadline has passed.
Tools Used Foundry , Manual Review
Recommendations Consider making the following change to the function. Add the revertIfDeadlinePassed modifier to the deposit function.
function deposit(
uint256 wethToDeposit,
uint256 minimumLiquidityTokensToMint,
uint256 maximumPoolTokensToDeposit,
uint64 deadline
)
external
+ revertIfDeadlinePassed(deadline)
revertIfZero(wethToDeposit)
returns (uint256 liquidityTokensToMint)
{
Rewards breakdown
nSLOC
276This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.