Submission Details
Severity:
Incorrect parameter logs in `TSwapPool::LiquidityAdded` event
Summary
values of wethDeposited and poolTokensDeposited are interchanged and doesn't match what is expected as shown below.
second and third place in parameters must be interchanged while emitting.
//expected
event LiquidityAdded(address indexed liquidityProvider, uint256 wethDeposited, uint256 poolTokensDeposited);
// emitted
emit LiquidityAdded(msg.sender, poolTokensToDeposit, wethToDeposit);
Impact
Systems reading Protocol logs like frontend or event indexers like The Graph protocol or any other off chain systems relying on protocol data will misinterpret the information logged due to the error
Recommendations
Make below code changes in TSwapPool.sol
function _addLiquidityMintAndTransfer(...){
.
.
.
- emit LiquidityAdded(msg.sender, poolTokensToDeposit, wethToDeposit);
+ emit LiquidityAdded(msg.sender, wethToDeposit, poolTokensToDeposit);
}
Updates
Appeal created
inallhonesty 11 months ago
Submission Judgement Published Assigned finding tags:
`LiquidityAdded` event has parameters out of order
Rewards breakdown
nSLOC
276This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.