Submission Details
Severity:
`swapExactInput` doesn't return expected `output` value
Summary
swapExactInput is expected to return correct calculated output value, instead it just returns the 0 value without it being assigned anywhere in the function call hence causing callers to believe output is 0.
Recommendations
Make below code changes in TSwap.sol
function swapExactInput(
...
)
...
returns (
- uint256 output
+ uint256 outputAmount
)
{
...
uint256 outputAmount = getOutputAmountBasedOnInput(inputAmount, inputReserves, outputReserves);
...
}
Updates
Appeal created
inallhonesty 11 months ago
Submission Judgement Published Assigned finding tags:
Default value returned by TSwapPool::swapExactInput results in incorrect return value given
Rewards breakdown
nSLOC
276This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.