Submission Details
Severity:
Front-run of the deposit due to ignored deadline
Summary
Front-run of the deposit due to ignored deadline.
Vulnerability Details
There's a revertIfDeadlinePassed(...) modifier that is implemented, it should revert if deadline is less than block.timestamp to protect from MEV front-run attacks on a user's deposit, some MEV bots can spot big deposits and act upon it. The deposit(...) function has a uint256 deadline parameter.
Impact
Front-run, even-though minimumLiquidityTokensToMint and maximumPoolTokensToDeposit add some safety.
Tools Used
Manual review
Recommendations
Add this line to the deposit(...) function
+ revertIfDeadlinePassed(deadline)
Updates
Appeal created
inallhonesty about 1 year ago
Submission Judgement Published Assigned finding tags:
`deposit` is missing deadline check causing transactions to complete even after the deadline
Rewards breakdown
nSLOC
276This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.