Submission Details
Severity:
TSwapToken.deposit does not check deadline
Summary
The deposit function has a deadline parameter but it is not enforced.
Vulnerability Details
https://github.com/agent3bood/2024-06-t-swap/blob/main/src/TSwapPool.sol#L117
Impact
Unexpected behavior by the protocol, when the user specify a deadline it should be enforced.
Tools Used
Recommendations
Add revertIfDeadlinePassed(deadline) modifier to the deposit function.
Updates
Appeal created
inallhonesty about 1 year ago
Submission Judgement Published Assigned finding tags:
`deposit` is missing deadline check causing transactions to complete even after the deadline
Rewards breakdown
nSLOC
276This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.