NFTBridge
60,000 USDC
View results
Submission Details
Severity: low
Invalid

The function `deposit_tokens` does not check the size of the serialized `buf`, which may cause failure due to gas exhaustion when withdrawing on L1.

Summary

The function deposit_tokens does not check the size of the serialized buf, which may cause failure due to gas exhaustion when withdrawing on L1.

Vulnerability Details

https://github.com/Cyfrin/2024-07-ark-project/blob/main/apps/blockchain/starknet/src/bridge.cairo#L292-L298

The function deposit_tokens does not check the size of the serialized buf, which may cause failure due to gas exhaustion when withdrawing on L1.

Impact

User can not withdraw on L1.

Tools Used

Vscode

Recommendations

Set a upper bound for buf.

Updates

Lead Judging Commences

n0kto Lead Judge 9 months ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement
Assigned finding tags:

Informational / Gas

Please, do not suppose impacts, think about the real impact of the bug and check the CodeHawks documentation to confirm: https://docs.codehawks.com/hawks-auditors/how-to-determine-a-finding-validity A PoC always helps to understand the real impact possible.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.