NFTBridge
60,000 USDC
View results
Submission Details
Severity: low
Invalid

State variable changed in `Escrow::_depositIntoEscrow` even if collectionType neither ERC721 nor ERC1155.

Summary

Escrow::_depositIntoEscrowthis function is intended to deposit in escrow and it should allow only ERC721 and ERC1155 collectionType, but with any collectionType it changes this mapping.

Vulnerability Details

_escrow this mapping also changes when any collectionType intended to deposit into escrow, but it should only allows ERC721 and ERC1155 collectionType.

_escrow[collection][id] = msg.sender;

Impact

Unnecessary state variable changed

Tools Used

Manual review

Recommendations

Check whether the collectionType should be ERC721 or ERC1155 in Escrow::_depositIntoEscrow function

Updates

Lead Judging Commences

n0kto Lead Judge 9 months ago
Submission Judgement Published
Invalidated
Reason: Design choice
Assigned finding tags:

invalid-tokens-with-other-standards-will-be-treated-like-ERC1155

No impact on the bridge or the users. If any NFT protocol use another standard with that bridge, they have to know how the bridge works and also that it doesn’t work with other standards at the moment.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.