HardhatFoundry
30,000 USDC
View results
Submission Details
Severity: low
Invalid

Unchecked External Call in _handleSingleExecution and _handleBatchExecution in Nexus Contract

Summary

The functions _handleSingleExecution and _handleBatchExecution make external calls without proper checks. This can lead to unexpected behavior, security vulnerabilities, and potential loss of funds.

Vulnerability Details

The functions _handleSingleExecution and _handleBatchExecution perform external calls without verifying the success of these calls. Unchecked external calls can lead to security issues if the called contract reverts or fails, leaving the current contract in an inconsistent state.

Impact

An attacker could:

  • Cause the contract to behave unexpectedly by ensuring that certain external calls fail.

  • Exploit the contract's reliance on unchecked external calls to perform unauthorized actions or manipulate the contract state.

Tools Used

Manual Review

Recommendations

  • Always check the return status of external calls and handle failures appropriately.

  • Use try/catch blocks to manage external call failures gracefully and ensure the contract remains in a consistent state.

  • Audit all external calls in the contract to ensure they are handled securely and appropriately.

Updates

Lead Judging Commences

0xnevi Lead Judge 11 months ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement
Assigned finding tags:

finding-unchecked-external-call

Invalid, eventually checked within `_execute()/_tryExecute()` and `_executeBatch()/_tryExecuteBatch(0` within `ExecutionHelper.sol` respectively as seen [here](https://github.com/Cyfrin/2024-07-biconomy/blob/9590f25cd63f7ad2c54feb618036984774f3879d/contracts/base/ExecutionHelper.sol)

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.