Submission Details
Severity:
updateReward(address(0), 0) modifier should be after function visibility.
Summary
TempleGoldStaking.sol: 180
the function distributeRewards() will not work correctly because the modifier is placed in the wrong place `
function distributeRewards() updateReward(address(0), 0) external {
if (distributionStarter != address(0) && msg.sender != distributionStarter)
{ revert CommonEventsAndErrors.InvalidAccess(); }
if (totalSupply == 0) { revert NoStaker(); }
`. Modifiers must be placed after the function visibility keyword and before the function body. This will result in a compilation error.
Vulnerability Details
This will result in a compilation error.
Impact
TGLD rewards will not be distributed to stakers. New rewardRate will not be calculated.
Tools Used
Recommendations
function distributeRewards() external updateReward(address(0), 0) {
Updates
Prize pool breakdown
Total prize
25,000 USDC
nSLOC
99825 USDC / LOC
20,000 USDC
2,500 USDC
2,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.