Submission Details
Severity:
Users are going to waste gas fees when migrating stakes to a new staking contract
Summary
When a new staking contract is available users can migrate to them by calling migrateWithdraw, to move their stake index to the new contract. However if a user have a large stake migrating them one by one will cost more gas for the user.
Vulnerability Details
function migrateWithdraw(address staker, uint256 index) external override onlyMigrator returns (uint256) {
if (staker == address(0)) { revert CommonEventsAndErrors.InvalidAddress(); }
StakeInfo storage _stakeInfo = _stakeInfos[staker][index];
uint256 stakerBalance = _stakeInfo.amount;
_withdrawFor(_stakeInfo, staker, msg.sender, index, _stakeInfo.amount, true, staker);
return stakerBalance;
}
Users only have the capacity to migrate one index at a time this might lead to loss of opportunity for staker if the new staking contract offers more rewards.
Impact
High gas fees to migrate large indexes and loss of opportunity.
Tools Used
Manual Review
Recommendations
Allow users migrate in batches
Prize pool breakdown
Total prize
25,000 USDC
nSLOC
99825 USDC / LOC
20,000 USDC
2,500 USDC
2,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.