Submission Details
Severity:
`ScoreBoard::isEligibleForReward` has a invalid verification that the user may lose the reward
Description
The function ScoreBoard::isEligibleForReward has a invalid verification that the user may lose the reward because verify if user has a more than one prediction fee (> 1), but in the docs the user could be at least one prediction fee (>=1), as we can se below:
function isEligibleForReward(address player) public view returns (bool) {
return
results[NUM_MATCHES - 1] != Result.Pending &&
playersPredictions[player].predictionsCount > 1; //here
}
Impact
If the player has only one prediction fee paid he will not win the rewards and loss the prize.
Recommended Mitigation
In the src/ScoreBoard.sol update the function check:
function isEligibleForReward(address player) public view returns (bool) {
return
results[NUM_MATCHES - 1] != Result.Pending &&
- playersPredictions[player].predictionsCount > 1;
+ playersPredictions[player].predictionsCount >= 1;
}
Updates
Lead Judging Commences
NightHawK 11 months ago
Submission Judgement Published Assigned finding tags:
The eligibility criteria is wrong
Players with only one prediction cannot withdraw.
Rewards breakdown
nSLOC
191This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.