Submission Details
Severity:
Unsafe casting of `int` to `uint` in `ThePredicter::withdraw`
Summary
Unsafe casting of int to uint in ThePredicter::withdraw
Vulnerability Details
In ThePredicter::withdraw the score variable which is an int8 is cast to an uint.
Impact
If the score variable is less than zero the resulting uint will be incorrect.
if (maxScore > 0 && score <= 0) { // if maxScore = 0 and score < 0
revert ThePredicter__NotEligibleForWithdraw();
}
uint256 shares = uint8(score); // if score = -1 then shares = 255
Tools Used
Manual Analysis
Recommendations
Add checks before casting.
Rewards breakdown
nSLOC
191This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.