Zaros Part 1

Summary

error in encoding data

Vulnerability Details

The error is in the decoding of peformData. The function is decoding peformData as if it only contains an array of uint128, but based on the checkUpkeep function, peformData (or extraData as it was called there) actually contains two pieces of information:

1. The array of account IDs to be liquidated

2. The address of the contract itself

This error means that the function is not correctly extracting all the data passed to it, potentially leading to unexpected behavior or reverts if the data is not in the expected format.

Impact

This error means that the function is not correctly extracting all the data passed to it, potentially leading to unexpected behavior or reverts if the data is not in the expected format.

Tools Used

Manual Review

Recommendations

(uint128[] memory accountsToBeLiquidated, address) = abi.decode(peformData, (uint128[], address));