Zaros Part 1

Summary

Unconditional upKeepNeeded leads to errors. upKeepNeeded is always set to true which defeats the purpose of the check function

Vulnerability Details

Unconditional upkeepNeeded: The callback function always sets upkeepNeeded to true without any actual checks or conditions. This means that the function will always indicate that an upkeep is needed, regardless of the actual state or data provided. The checkCallback is supposed to determine whether an upkeep is actually needed based on the provided data.

Impact

It could lead to unnecessary upkeep operations, potentially wasting gas and resources. It doesn't take into account any conditions from the signedReport or extraData that might indicate whether an upkeep is truly needed.

Tools Used

Manual Review

Recommendations

Add logic to determine if upkeep is needed based on signedReport and possibly extraData