Submission Details
Severity:
Logic Flaw
Summary
incorrect logic of closing the pot, there still will be tokens left , it must be (remainingRewards - managerCut) / claimants.length
Vulnerability Details
in Pot.sol , line 57
function closePot() external onlyOwner {
if (block.timestamp - i_deployedAt < 90 days) {
revert Pot__StillOpenForClaim();
}
if (remainingRewards > 0) {
uint256 managerCut = remainingRewards / managerCutPercent;
i_token.transfer(msg.sender, managerCut);
// @audit incorrect logic of closing the pot, there still will be tokens left , it must be (remainingRewards - managerCut) / claimants.length
uint256 claimantCut = (remainingRewards - managerCut) / i_players.length;
for (uint256 i = 0; i < claimants.length; i++) {
_transferReward(claimants[i], claimantCut);
}
}
}
Impact
not all tokens in pot will be distributed
Tools Used
eyes
Recommendations
do
(remainingRewards - managerCut) / claimants.length
Updates
Lead Judging Commences
equious about 1 year ago
Submission Judgement Published Assigned finding tags:
Incorrect distribution in closePot()
Rewards breakdown
nSLOC
106This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.