Submission Details
Severity:
DoS
Summary
in certain conditions transaction will run out of gas and revert, causing DoS
Vulnerability Details
in Pot.sol, lines 58-60
if there are too many claimants, transaction will run out of gas and revert, causing DoS
function closePot() external onlyOwner {
if (block.timestamp - i_deployedAt < 90 days) {
revert Pot__StillOpenForClaim();
}
if (remainingRewards > 0) {
uint256 managerCut = remainingRewards / managerCutPercent;
i_token.transfer(msg.sender, managerCut);
uint256 claimantCut = (remainingRewards - managerCut) / i_players.length;
// @audit bad practice! if there are too many claimants, the transaction will run out of gas and revert
for (uint256 i = 0; i < claimants.length; i++) {
_transferReward(claimants[i], claimantCut);
}
}
Impact
Pot can never be closed
Tools Used
brain
Recommendations
make another claim mechanism for remaining tokens, this time for claimants only
Updates
Lead Judging Commences
equious about 1 year ago
Submission Judgement Published Assigned finding tags:
Unbound loop in closePot
Rewards breakdown
nSLOC
106This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.