Submission Details
Severity:
Constants should be named in uppercase and with underscores
Summary
Constant values in the code should be in uppercase and with underscores in order to maintain solidity naming conformations.
Vulnerability Details
LoC:
https://github.com/Cyfrin/2024-08-MyCut/blob/946231db0fe717039429a11706717be568d03b54/src/Pot.sol#L20
Impact
No such impact, provides more clarity
Tools Used
Manual Review
Recommendations
Make the following changes:
- uint256 private constant managerCutPercent = 10;
+ uint256 private constant MANAGER_CUT_PERCENT = 10;
Rewards breakdown
nSLOC
106This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.