Submission Details
Severity:
Use `i_` prefix only for immutable variables
Summary
i_ prefix is used only for immutable variables present in a contract.
Vulnerability Details
LoC:
https://github.com/Cyfrin/2024-08-MyCut/blob/946231db0fe717039429a11706717be568d03b54/src/Pot.sol#L12
https://github.com/Cyfrin/2024-08-MyCut/blob/946231db0fe717039429a11706717be568d03b54/src/Pot.sol#L13
These two arrays are storage variables, and not immutable.
Impact
Maintaining solidity naming conventions
Tools Used
Manual Review
Recommendations
Make the following changes:
- address[] private i_players;
- uint256[] private i_rewards;
+ address[] private s_players;
+ uint256[] private s_rewards;
OR
+ address[] private players;
+ uint256[] private rewards;
Rewards breakdown
nSLOC
106This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.