MyCut

First Flight #23
Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: medium
Invalid

The return value from the token transfer is not checked.

Vulnerability Details

Some ERC20 tokens don't throw but just return false when a transfer fails. This can lead to a loss of funds when users try to claimCut, if the recipient tries to claimCut before rewards are sent to the pot, it will revert with most tokens, but for tokens with this vulnerability the transaction will go through and the user won't get their funds. A good example of such a token is ZRX: Etherscan code.

Impact

Loss of funds

Tools Used

Slither

Recommendations

Use SafeErc20 to mitigate this issue as well as others like it.

Updates

Lead Judging Commences

equious Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Known issue

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.