MyCut

First Flight #23
Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: medium
Invalid

Problems Closing the Contest

Summary

Errors in closePot might leave the contest open indefinitely or result in the misdistribution of rewards.

Vulnerability Details

If closing the contest fails due to issues like token transfer errors or insufficient rewards, the contract does not handle these failures properly, leaving it in a bad state.

Impact

Rewards might not be distributed, or the contract may get stuck in an open state, leading to a breakdown in reward distribution.

Tools Used

Manual review

Recommendations

Add proper checks and a fallback mechanism to ensure all rewards are handled properly even if an error occurs.

try i_token.transfer(msg.sender, managerCut) {
// Success logic
} catch {
// Handle failure
}
Updates

Lead Judging Commences

equious Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Lack of quality

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.