Submission Details
Severity:
Change condition check in claimCut function (Pot.sol::Line 40)
Summary
reward will never be < 0. Change to == 0
Vulnerability Details
function claimCut() public {
address player = msg.sender;
uint256 reward = playersToRewards[player];
if (reward <= 0) {
revert Pot__RewardNotFound();
}
playersToRewards[player] = 0;
remainingRewards -= reward;//@audit underflow ever possible?
claimants.push(player);
_transferReward(player, reward);
}
Impact
Ineffecient gas use.
Tools Used
Manual Review
Recommendations
Change line 4 check to == instead of <=.
Rewards breakdown
nSLOC
106This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.