MyCut

Summary

The Ownable constructor is incorrectly invoked with msg.sender in Pot.sol. Despite the Ownable contract from OpenZeppelin automatically setting the owner to the msg.sender during deployment. This misuse of inheritance could lead to potential deployment issues.

Vulnerability Details

Impact

Could also lead to an incorrect assignment of ownership or unexpected behavior, which is critical for access control and could result in the loss of administrative rights.

Tools Used

Manual Review

Recommendations

The msg.sender should not be passed to Ownable since the Ownable contract already handles the owner assignment internally. The contract should transfer ownership within the constructor.