Tadle
Tadle
DeFi
30,000 USDC
View results
Previous Next
Submission Details
Severity: low
Valid

Anyone can call CapitalPool::approve()

decap

Summary

CapitalPool::approve()is missing access modifier, so anyone can call this function.

Proof of Code

Add this test to PreMarkets.t.sol

function test_anyoneCanApproveTokenForTokenManager() public{
vm.startPrank(user2);
vm.expectRevert();
capitalPool.approve(address(mockUSDCToken));
vm.stopPrank();
}

run forge test --mt test_anyoneCanApproveTokenForTokenManager -vvv

Test will fail as this line does not revert.

Impact

Medium/Low

Tools Used

Manual review, foundry

Recommendations

Add access check

function approve(address tokenAddr) external {
address tokenManager = tadleFactory.relatedContracts(
RelatedContractLibraries.TOKEN_MANAGER
);
​
+ if(msg.sender != tokenManager){
+ revert();
+ }
(bool success, ) = tokenAddr.call(
abi.encodeWithSelector(
APPROVE_SELECTOR,
tokenManager,
type(uint256).max
)
);
​
if (!success) {
revert ApproveFailed();
}
}
Updates

Lead Judging Commences

0xnevi Lead Judge 10 months ago
Submission Judgement Published
Validated
Assigned finding tags:

finding-CapitalPool-approve-missing-access-control

This is at most low severity, even though giving max approvals shouldn't be permisionless, the respective tokenManager address is retrieved from the TadleFactory contract whereby the trusted guardian role is responsible for deploying such contracts as seen [here](https://github.com/Cyfrin/2024-08-tadle/blob/04fd8634701697184a3f3a5558b41c109866e5f8/src/factory/TadleFactory.sol#L68). Since the user still has to go through the PreMarkets/DeliveryPlace contracts to perform market actions, this max approval cannot be exploited.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.