Tadle
Tadle
DeFiFoundry
27,750 USDC
View results
Previous Next
Submission Details
Severity: high
Valid

Lack of Access Control in `updateReferrerInfo` Function

brene

Summary

The updateReferrerInfo function in the SystemConfig contract lacks proper access control, allowing any user to update referrer information. This can lead to unauthorized modifications and potential exploitation.

Vulnerability Details

No access control mechanism is implemented in updateReffererInfo, allowing any user to call this function.

Impact

Any user can update referrer information, leading to potential manipulation and unauthorized changes. Malicious actors can exploit this to disrupt the referral system, potentially causing financial losses or system instability.

Tools Used

Manual Review

Recommendations

Implement access control to restrict who can call the updateReferrerInfo function.

function updateReferrerInfo(
address _referrer,
uint256 _referrerRate,
uint256 _authorityRate
- ) external {
- if (_msgSender() == _referrer) {
- revert InvalidReferrer(_referrer);
- }
+ ) external onlyOwner)
if (_referrer == address(0x0)) {
revert Errors.ZeroAddress();
}
​
if (_referrerRate < baseReferralRate) {
revert InvalidReferrerRate(_referrerRate);
}
Updates

Lead Judging Commences

0xnevi Lead Judge about 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

finding-SystemConfig-updateReferrerInfo-msgSender

Valid high severity. There are two impacts here due to the wrong setting of the `refferalInfoMap` mapping. 1. Wrong refferal info is always set, so the refferal will always be delegated to the refferer address instead of the caller 2. Anybody can arbitrarily change the referrer and referrer rate of any user, resulting in gaming of the refferal system I prefer #1500 description the most, be cause it seems to be the only issue although without a poc to fully describe all of the possible impacts

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.