Referrers are able to do race-condition attack, increasing the referral rate/ authority rate
Takers can bid for orders created by makers.
It fetches the referrer details from getReferralInfo
The problem is any of the parameters in referralInfoMap
can be frontrunned and updated before the function call, to make the user pay more on remainingPlatformFee
the updateReferral Info
can be called by anyone to update the Referral Parameters
If Referral Info parameters are changed in between the taker submitting a bid transaction and the transaction being applied, taker may be subject to changes in referralInfoMap
Manual Review
Take every single parameters as input of createTaker()
(including referal parameters) and compare them to the values in SystemConfig
Valid high severity. There are two impacts here due to the wrong setting of the `refferalInfoMap` mapping. 1. Wrong refferal info is always set, so the refferal will always be delegated to the refferer address instead of the caller 2. Anybody can arbitrarily change the referrer and referrer rate of any user, resulting in gaming of the refferal system I prefer #1500 description the most, be cause it seems to be the only issue although without a poc to fully describe all of the possible impacts
The contest is live. Earn rewards by submitting a finding.
This is your time to appeal against judgements on your submissions.
Appeals are being carefully reviewed by our judges.