Tadle
Tadle
DeFiFoundry
27,750 USDC
View results
Previous Next
Submission Details
Severity: low
Invalid

Lack of address zero check in `TaddleFactory` constructor

spomaria

Summary

The constructor of the TaddleFactory.sol contract sets the guardian who is the admin. The guardian has certain admin privileges such as deployment of upgradeable proxies.

Vulnerability Details

The constructor function lacks address(0) check which means an address(0) can be set as the guardian.

constructor(address _guardian) {
guardian = _guardian;
}

Impact

Allowing a zero address to be the guardian will disrupt some of the protocol functionalities that are only delegated to the guardian for which there is check against the zero address

Tools Used

Manual Review

Recommendations

Consider adding the zero address check in the constructor function

constructor(address _guardian) {
+ if(_guardian == address(0)) {
+ revert();
+ }
​
guardian = _guardian;
}

This will ensure that the zero address is not set as the guardian

Updates

Lead Judging Commences

0xnevi Lead Judge
about 1 year ago
0xnevi Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Known issue

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.