Submission Details
Severity:
Unnecessary Getter in `SystemConfig.sol`
Summary
Some variables are declared as public in the storage contract (SystemConfigStorage.sol) and also have getter functions in the main contract. This is redundant as public variables automaticaly generate getter functions.
function getBaseReferralRate() external view returns (uint256) {
return baseReferralRate;
}
function getReferralInfo(
address _referrer
) external view returns (ReferralInfo memory) {
return referralInfoMap[_referrer];
}
function getMarketPlaceInfo(
address _marketPlace
) external view returns (MarketPlaceInfo memory) {
return marketPlaceInfoMap[_marketPlace];
}
Tools Used
Manual Review
Recommendations
Remove the getters function
Prize pool breakdown
Total prize
27,750 USDC
nSLOC
1,22923 USDC / LOC
25,000 USDC
2,750 USDC
2,250 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.