Submission Details
Severity:
Bid offers can not be closed on calling `closeBidOffer` function
Summary
The closeBidOffer function includes a check to ensure that only offers with a status of "Virgin" can be closed. If an offer's status is anything other than Virgin, the function will revert with an InvalidOfferStatus error. This restriction prevents the closure of ongoing offers.
Vulnerability Details
In the closeBidOffer function, there is a check to determine whether the offer status is Virgin upon closing, meaning only Virgin offers can be closed when this function is called, as shown below.
if (offerInfo.offerStatus != OfferStatus.Virgin) {
revert InvalidOfferStatus();
}
This will make it impossible to close ongoing offers.
Impact
Bid offers can not be closed
Tools Used
Manual Review
Recommendations
- if (offerInfo.offerStatus != OfferStatus.Virgin) {
+ if (offerInfo.offerStatus == OfferStatus.Virgin) {
revert InvalidOfferStatus();
}
Prize pool breakdown
Total prize
30,000 USDC
nSLOC
1,22924 USDC / LOC
25,000 USDC
2,750 USDC
2,250 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.