Submission Details
Severity:
Potential Underflow Risk in Abort Ask Offer Refund Calculation
Vulnerability Details
In the abortAskOffer function, there's a subtraction operation that could potentially underflow if transferAmount is only slightly larger than totalDepositAmount and precision loss occurs in earlier calculations.
Impact
An underflow in this calculation could result in an incorrect makerRefundAmount, potentially leading to significant financial losses for users or the platform.
Proof of Concept
function demonstrateUnderflowRisk(uint256 transferAmount, uint256 totalDepositAmount) public pure returns (uint256) {
if (transferAmount > totalDepositAmount) {
unchecked {
return transferAmount - totalDepositAmount;
}
} else {
return 0;
}
}
// Example:
// demonstrateUnderflowRisk(100, 99)
// This works fine, returning 1
// However:
// demonstrateUnderflowRisk(2^256 - 1, 2^256 - 2)
// This will return a very large number due to underflow, instead of 1
Tools Used
Manual Review
Recommendations
Implement a safety check to ensure the subtraction doesn't underflow:
require(transferAmount >= totalDepositAmount, "Underflow risk");
makerRefundAmount = transferAmount - totalDepositAmount;
Prize pool breakdown
Total prize
27,750 USDC
nSLOC
1,22923 USDC / LOC
25,000 USDC
2,750 USDC
2,250 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.