Tadle

Summary

When listing an offer in PreMarkert::listOfferin Turbo Mode, the contract updates the AbortOfferStatus to show that a sub-Offer has been listed but the variable(originOfferInfo) is in memory hence this assignment is not stored in persitent Storage to be seen by other functions.

Vulnerabilty Details

In PreMarkert::listOffer, checks are made to see if the originOffer of the maker of the stock to be listed is in turbo mode inorder to specify whether it has a subOffer or not.

• PreMarkert.sol Line 335

The information about this originOffer is fetched and stored in a variable calledoriginOfferInfo, but this variable is in memory but not storage;-

• PreMarkert.sol Line 336

This makes the assignment below to be lost at the end of the function's excution, and the AbortOfferStatus of this offer won`t change to be utilised/seen by other functions.

• PreMarkert.sol Line 342

Impact

The originOffer's offerSettleType won't be updated and will remain in initialized after the end of the function execution making other function which check this state like preMarkets::abortAskOffer unable to know the offer's collect state, hence can be aborted and collateral refunded, making the Sublisted offer to be without collateral since its in turbo mode.

Tools Used

Manual Review

Recommendation

Consider changing the memory keyword to Storage in PreMarkert::listOffer when an offer is in trubo mode to ensure all changes made to it are stored permanently.