Tadle

Summary

DeliveryPlace contract exposes the below external functions, but the same are not listed in the IDeliveryPlace interface. Due to this, clients holding reference to IDeliveryPlace interface will not be able to call any of these functions.

As these functions are not listed in the interface, clients holding reference to IDeliveryPlace will not be able to make any of these calls.
Infact, IDeliveryPlace does not have any functions.

Vulnerability Details

The interface is often referred as protocol for communication, ensure that parties involved in the communication knows to the extent they should know. Other unnecessary details are hidden.

But, the IDeliveryPlace interface does not seem to adhere to the standard convention. So any client that needs to call any of the above listed function should hold reference to the contract instance as the interface is not aware of the external functions.

This defeats the purpose of have interface to certain extent.

Impact

All clients that needs to call the below functions will have to by pass the IDeliveryPlace interface and should hold reference to DeliveryPlace contract instance.

Tools Used

Manual Review

Recommendations

Add the below functions to the IDeliveryPlace interface and override them in the implementation contract.