Tadle

Summary

In the current implementation of the relistOffer function, when an offer that was partially filled and then canceled is relisted, the usedPoints are not reset. This means that the relisted offer retains the usedPoints from its previous state.

Impact

1. The relisted offer appears to have less available capacity than it actually does, as the usedPoints from the previous listing are still counted.

2. Other parts of the contract use usedPoints to calculate available amounts or settle trades, it could lead to incorrect calculations and potentially financial losses for users.

3. The offer's state becomes inconsistent, as a freshly relisted offer should logically start with zero used points.

Code

https://github.com/Cyfrin/2024-08-tadle/blob/04fd8634701697184a3f3a5558b41c109866e5f8/src/core/PreMarkets.sol#L524

Mitigation

Reset the usedPoints to zero when relisting the offer. Here's how we can modify the affected part of the code: