Tadle
Tadle
DeFiFoundry
27,750 USDC
View results
Previous Next
Submission Details
Severity: low
Invalid

There is no check to confirm that MarketPlace is online when aborting bid offer

Franklin

Impact
In abortBidTaker, there is no check to confirm that marketplace is online when aborting bid. This may result in offer owners not being able to abort their bids if marketplace is down/offline.

https://github.com/Cyfrin/2024-08-tadle/blob/04fd8634701697184a3f3a5558b41c109866e5f8/src/core/PreMarkets.sol#L645

Tools Used
Manual Review

Recommendations

Include a check in abortBidTaker to check the status of the marketplace and confirm it is online when aborting bids. Similarly like it was done in abortAskTaker.

+ ISystemConfig systemConfig = tadleFactory.getSystemConfig();`
​
+ MakerInfo storage makerInfo = makerInfoMap[offerInfo.maker];`
​
+ MarketPlaceInfo memory marketPlaceInfo = systemConfig`.getMarketPlaceInfo(makerInfo.marketPlace);`
​
+ marketPlaceInfo.checkMarketPlaceStatus(`block.timestamp, MarketPlaceStatus.Online);`
​
Updates

Lead Judging Commences

0xnevi Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Known issue
Assigned finding tags:

[invalid] finding-Admin-Errors-Malicious

The following issues and its duplicates are invalid as admin errors/input validation/malicious intents are1 generally considered invalid based on [codehawks guidelines](https://docs.codehawks.com/hawks-auditors/how-to-determine-a-finding-validity#findings-that-may-be-invalid). If they deploy/set inputs of the contracts appropriately, there will be no issue. Additionally admins are trusted as noted in READ.ME they can break certain assumption of the code based on their actions, and

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.