Tadle
Tadle
DeFiFoundry
27,750 USDC
View results
Previous Next
Submission Details
Severity: high
Valid

Anyone can execute updateReferrerInfo and set favorable values for themselves.

ge6a

Summary

The updateReferrerInfo() function in the SystemConfig contract allows setting the referrerRate and authorityRate for the respective referrer address. The problem is that any account other than the respective referrer can change these values and set a new ratio between referrerRate and authorityRate

Vulnerability Details

The function has some restrictions:

  • _referrerRate must be >= baseReferralRate.

  • referrerRate + _authorityRate = baseReferralRate + referralExtraRate

where referralExtraRate is set by the owner of the contract. For example, if baseReferralRate is 30% and referralExtraRate is 20%, then any account other than the referrer can set _referrerRate in the range [30%, 50%] and _authorityRate in the range [0%, 20%]. It is evident that it is more advantageous for the referrer to have the referrerRate at its maximum value, while it is more advantageous for the authority to have the _authorityRate at its maximum value. This can be seen in the source code below:

function updateReferrerInfo(
address _referrer,
uint256 _referrerRate,
uint256 _authorityRate
) external {
if (_msgSender() == _referrer) {
revert InvalidReferrer(_referrer);
}
​
​
if (_referrer == address(0x0)) {
revert Errors.ZeroAddress();
}
​
​
if (_referrerRate < baseReferralRate) {
revert InvalidReferrerRate(_referrerRate);
}
​
​
uint256 referralExtraRate = referralExtraRateMap[_referrer];
uint256 totalRate = baseReferralRate + referralExtraRate;
​
​
if (totalRate > Constants.REFERRAL_RATE_DECIMAL_SCALER) {
revert InvalidTotalRate(totalRate);
}
​
​
if (_referrerRate + _authorityRate != totalRate) {
revert InvalidRate(_referrerRate, _authorityRate, totalRate);
}

https://github.com/Cyfrin/2024-08-tadle/blob/04fd8634701697184a3f3a5558b41c109866e5f8/src/core/SystemConfig.sol#L41-L67

Impact

Referrer or authority may loose the profit they deserve because of missing access control and opportunity for race condition on the updateReferrerInfo() function.

Tools Used

Manual review

Recommendations

Not sure what is the best solution here but this way the source code is not ok.

Updates

Lead Judging Commences

0xnevi Lead Judge about 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

finding-SystemConfig-updateReferrerInfo-msgSender

Valid high severity. There are two impacts here due to the wrong setting of the `refferalInfoMap` mapping. 1. Wrong refferal info is always set, so the refferal will always be delegated to the refferer address instead of the caller 2. Anybody can arbitrarily change the referrer and referrer rate of any user, resulting in gaming of the refferal system I prefer #1500 description the most, be cause it seems to be the only issue although without a poc to fully describe all of the possible impacts

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.