Submission Details
Severity:
Event Emission Before Sate Changes
Summary
The events TillIn, AddTokenBalance, etc., should be emitted after the state is reflected when the event is emitted. Emitting events before state changes could result in inconsistency.
Vulnerability Details
An event could be emitted with incorrect data if a transaction reverts after the event is emitted
Impact
These could lead to misleading event logs, making it difficult to audit the contract's history.
Tools Used
Manual review
CODE SNIPPET
function tillIn(
address accountAddress,
address tokenAddress,
uint256 amount,
bool isPointToken
) external payable;
Recommendations
Ensure all state changes occur before the event emission.
function tillIn(
address accountAddress,
address tokenAddress,
uint256 amount,
bool isPointToken
) external payable{
//state changes
emit TillIn(accountAddress,
tokenAddress, amount, isPointToken);
}
Prize pool breakdown
Total prize
27,750 USDC
nSLOC
1,22923 USDC / LOC
25,000 USDC
2,750 USDC
2,250 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.