Potential Reversion in TokenManager::withdraw Due to Gas Limitation in ETH Transfer
Summary
In the TokenManager::withdraw function, the transfer method is used to send ETH, but it's limited to 2300 gas. This could cause the transaction to revert if the recipient requires more gas to process the transfer.
Vulnerability Details
The withdraw function transfers ETH to the msg.sender when dealing with a wrapped native ETH token. The protocol uses the transfer function, which is constrained to 2300 gas. If the msg.sender requires more gas to accept the ETH, the transfer will fail and revert the transaction.
Impact
Withdrawals could fail due to insufficient gas, causing issues for users who need more than 2300 gas to receive ETH.
Tools Used
Manual review
Recommendations
Replace the transfer function with a call function that includes a success check to ensure the transfer completes even if more gas is needed
Lead Judging Commences
[invalid] finding-TokenManager-withdraw-transfer-2300-gas
Invalid, known issues [Medium-2](https://github.com/Cyfrin/2024-08-tadle/issues/1)
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.