Tadle

Summary

An incorrect offerId is assigned to the PreMarkets:stockInfoMap and PreMarkets:offerInfoMap, leading to a mismatch between the offer identifiers used to generate addresses and the identifiers stored in these mappings.

Vulnerability Details

The PreMarkets:createOffer function is responsible for creating an offer by generating addresses for makerInfoMap, offerInfoMap, and stockInfoMap, each associated with an offerId. The addresses are created as follows:
https://github.com/Cyfrin/2024-08-tadle/blob/04fd8634701697184a3f3a5558b41c109866e5f8/src/core/PreMarkets.sol#L67-L69

As the execution proceeds, the offerId is incremented:

https://github.com/Cyfrin/2024-08-tadle/blob/04fd8634701697184a3f3a5558b41c109866e5f8/src/core/PreMarkets.sol#L83

After this increment, the mappings makerInfoMap, offerInfoMap, and stockInfoMap are fetched using the previously generated addresses makerAddr, offerAddr, and stockAddr. However, the id fields in the offerInfoMap and stockInfoMap structs are set to the new, incremented offerId, which differs from the offerId initially used to generate the addresses.
https://github.com/Cyfrin/2024-08-tadle/blob/04fd8634701697184a3f3a5558b41c109866e5f8/src/core/PreMarkets.sol#L116-L146

This results in a misalignment between the offerId used to create the addresses and the offerId stored in the mappings, potentially causing inconsistencies and errors in the offer-related data.

Impact

Misalignment between the offerId used to create the addresses and the offerId stored in the mappings

Tools Used

Manually

Recommendations

Use correct offerId update it later